[Webkit-unassigned] [Bug 125926] [GStreamer] WebKit gets stalled when trying to play a stream

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125926





--- Comment #9 from Eric Carlson <eric.carlson at apple.com>  2014-02-25 07:37:10 PST ---
(From update of attachment 225065)
View in context: https://bugs.webkit.org/attachment.cgi?id=225065&action=review

> LayoutTests/http/tests/media/resources/stream/media.db:1
> +a:4:{i:0;a:11:{s:8:"fileName";s:11:"silence.m4a";s:8:"fileSize";i:20447;s:8:"playTime";d:1.3699773242630386;s:10:"audioStart";i:4096;s:8:"audioEnd";i:20447;s:11:"audioLength";i:16351;s:6:"artist";s:7:"silence";s:5:"title";N;s:7:"bitRate";d:95481.87235169491;s:8:"mimeType";s:9:"audio/aac";s:10:"fileFormat";s:3:"mp4";}i:1;a:11:{s:8:"fileName";s:11:"silence.mp3";s:8:"fileSize";i:17961;s:8:"playTime";d:1.4105833333333333;s:10:"audioStart";i:1034;s:8:"audioEnd";i:17961;s:11:"audioLength";i:16927;s:6:"artist";s:7:"silence";s:5:"title";N;s:7:"bitRate";i:96000;s:8:"mimeType";s:10:"audio/mpeg";s:10:"fileFormat";s:3:"mp3";}i:2;a:11:{s:8:"fileName";s:11:"silence.oga";s:8:"fileSize";i:12983;s:8:"playTime";d:1.3844897959183673;s:10:"audioStart";i:172;s:8:"audioEnd";i:10460;s:11:"audioLength";i:10288;s:6:"artist";s:7:"silence";s:5:"title";N;s:7:"bitRate";d:59447.16981132076;s:8:"mimeType";s:9:"audio/ogg";s:10:"fileFormat";s:3:"ogg";}i:3;a:11:{s:8:"fileName";s:11:"silence.wav";s:8:"fileSize";i:120876;s:8:"playTime";d:1.3699773242630386;s:10:"audioStart";i:44;s:8:"audioEnd";i:120876;s:11:"audioLength";i:120832;s:6:"artist";s:7:"silence";s:5:"title";N;s:7:"bitRate";i:705600;s:8:"mimeType";s:9:"audio/wav";s:10:"fileFormat";s:4:"riff";}}

How was this database generated, with getid3? Please a script to your patch so someone later can regenerate it if necessary.

> LayoutTests/http/tests/media/resources/stream/stream-media.php:13
> +    /* $fileName = basename($filePath); */

Nit: if this was left here for a purpose, please say so in a comment. if not, please remove.

> LayoutTests/http/tests/media/resources/stream/stream-media.php:21
> +    $ranges = array_key_exists("ranges", $_GET) ? $_GET["ranges"] : "yes";

Is there any reason to not use byte ranges?

> LayoutTests/http/tests/media/resources/stream/stream-media.php:22
> +    $setMetadata = array_key_exists("send-metaint", $_GET) ? $_GET["send-metaint"] : "no";

Is there any reason to not send metadata?

> LayoutTests/http/tests/media/resources/stream/stream-media.php:106
> +    if ($httpStatus == "404 Not Fond")
> +        exit;

It would be good to fail with something more informative than a 404. Is it possible to log something to stderr so it shows up in the test results?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.