[Webkit-unassigned] [Bug 129154] An element having -webkit-mix-blend mode should only blend with the contents of the parent stacking context
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Feb 22 16:08:55 PST 2014
https://bugs.webkit.org/show_bug.cgi?id=129154
Dean Jackson <dino at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #224877|review? |review+
Flag| |
--- Comment #2 from Dean Jackson <dino at apple.com> 2014-02-22 16:06:03 PST ---
(From update of attachment 224877)
View in context: https://bugs.webkit.org/attachment.cgi?id=224877&action=review
> Source/WebCore/ChangeLog:9
> + This change isolates blending, preventing it to blend with other underlying elements besides the parent stacking context.
Typo "to" -> "from"
> Source/WebCore/rendering/RenderLayer.cpp:814
> + if (!oldStyle && renderer().style().hasBlendMode())
> + m_updateParentStackingContextShouldIsolateBlendingDirty = true;
> +
> + if (oldStyle && oldStyle->hasBlendMode() != renderer().style().hasBlendMode())
> + m_updateParentStackingContextShouldIsolateBlendingDirty = true;
Make this one test, even though it will be long.
> Source/WebCore/rendering/RenderLayer.h:785
> #if ENABLE(CSS_COMPOSITING)
> bool hasBlendMode() const { return renderer().hasBlendMode(); }
> + bool isolatesBlending() const { return m_isolatesBlending; }
> #else
> bool hasBlendMode() const { return false; }
> + bool isolatesBlending() const { return false; }
> #endif
I think it would be better to write these the other way around:
bool isolatesBlending() const
{
#if ENABLE(CSS_COMPOSITING)
return m_isolatesBlending;
#else
return false;
#endif
}
Same for hasBlendMode
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list