[Webkit-unassigned] [Bug 129192] New: A64DOpcodeBitfield::format contains unreachable code

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129192

           Summary: A64DOpcodeBitfield::format contains unreachable code
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: joepeck at webkit.org
                CC: joepeck at webkit.org, msaboff at apple.com


There is unreachable code in A64DOpcodeBitfield::format:

    const char* A64DOpcodeBitfield::format()
    {
        ...

        if (opc() == 0x2 && immediateS() == (immediateR() + 1)) {
            // lsl
            ...
            return m_formatBuffer;
        } else if (!(opc() & 0x1) && ((immediateS() & 0x1f) == 0x1f) && (is64Bit() == (immediateS() >> 5))) {
            // asr/lsr
            ...
            return m_formatBuffer;
        } else if (immediateS() < immediateR()) {
            // bit field insert
            ...
            return m_formatBuffer;
        } else {
            // bit field extract
            ...
            return m_formatBuffer;
        }

        appendInstructionName(opName());
        appendRegisterName(rd(), is64Bit());
        appendSeparator();
        appendRegisterName(rn(), is64Bit());
        appendSeparator();
        appendUnsignedImmediate(immediateR());
        appendSeparator();
        appendUnsignedImmediate(immediateS());

        return m_formatBuffer;
    }

Should this code be reachable somehow, or can it just be removed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.