[Webkit-unassigned] [Bug 128422] Web Inspector: update check-webkit-style to flag single quotes in WebInspectorUI projects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128422





--- Comment #20 from Diego Pino <dpino at igalia.com>  2014-02-21 02:35:03 PST ---
(From update of attachment 224749)
View in context: https://bugs.webkit.org/attachment.cgi?id=224749&action=review

>> Tools/Scripts/webkitpy/style/checkers/js.py:67
>> +            if (line.endswith("*/")):
> 
> We have had cases where there is a space after the comment ends that this wouldn't catch.

Line is stripped, that means that leading and trailing whitespace characters are removed before the check.
http://docs.python.org/2/library/string.html

>> Tools/Scripts/webkitpy/style/checkers/js.py:76
>> +            line = re.compile(r'"(?:[^"\\]|\\.)*"', re.MULTILINE).sub('""', line)
> 
> Nit: I don't think you need re.MULTILINE. The input string (line) is only a single line anyways right?

OK

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.