[Webkit-unassigned] [Bug 129145] New: [GTK] Bug in webkit_dom_range_compare_boundary_points GObject DOM API function

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=129145

           Summary: [GTK] Bug in webkit_dom_range_compare_boundary_points
                    GObject  DOM API function
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: tpopela at redhat.com


In GObject DOM API there is a webkit_dom_range_compare_boundary_points function ( https://developer.mozilla.org/en-US/docs/Web/API/Range.compareBoundaryPoints ) that takes second argument "how" that's type is CompareHow (in GObject DOM API it is defined as gushort). CompareHow is enum defined in http://trac.webkit.org/browser/trunk/Source/WebCore/dom/Range.h#L87 . The problem is that START_TO_START is defined first so it has value 0, but the generator is not counting with it and it generates g_return_val_if_fail (how, 0) in WebKitDOMRange.cpp. Thus we will get a nice runtime warning: CRITICAL **: gshort webkit_dom_range_compare_boundary_points(WebKitDOMRange*, gushort, WebKitDOMRange*, GError**): assertion 'how' failed . So the generator should be aware of CompareHow while generating the g_return_* macros.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.