[Webkit-unassigned] [Bug 128092] Web Inspector: RuntimeManager should not use view object WebInspector.quickConsole

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128092


Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #224720|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #3 from Timothy Hatcher <timothy at apple.com>  2014-02-20 08:35:20 PST ---
(From update of attachment 224720)
View in context: https://bugs.webkit.org/attachment.cgi?id=224720&action=review

> Source/WebInspectorUI/UserInterface/RuntimeManager.js:76
> +        if (!contextId) {
> +            contextId = WebInspector.quickConsole.executionContextIdentifier;
> +        }

Passing in the contextId (preferably contextIdentifier) is the right approach.

The idea of this bug was to remove the use of WebInspector.quickConsole altogether, not just hide it behind an optional argument.

I also don't see where anyone is passing a context to evaluateInInspectedWindow in this patch, so nothing has really changed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.