[Webkit-unassigned] [Bug 113583] [GTK] Add API for remembering visited links

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113583





--- Comment #9 from Giovanni Campagna <scampa.giovanni at gmail.com>  2014-02-19 18:22:45 PST ---
(In reply to comment #5)
> (From update of attachment 195746 [details])
> > Source/WebKit2/UIProcess/API/gtk/WebKitHistoryClient.cpp:46
> > +        0, // didNavigateWithNavigationData
> > +        0, // didPerformClientRedirect
> > +        0, // didPerformServerRedirect
> > +        0, // didUpdateHistoryTitle
> > +        populateVisitedLinks,
> 
> Is it enough with populate-visited-links signal + add_visited_link method to maintain an external visited link storage? I guess we also need to implement didNavigateWithNavigationData to let the user know when the visited links storage should be updated, no?
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:82
> > +    POPULATE_VISITED_LINKS,
> 
> Do we plan to implement all other callbacks of the history client? Maybe we could move this to a separate object WebKitHistoryManager, or just WebKitHistory simialr to the cookie manager, geolocation provider or favicon database. Maybe we could use different objects one for visited links, WebKitVisitedLinksManager/Provider and another for the global history, that would allow us to implement only the visited links API now and decide about the global history in the future.

So, this API is designed for epiphany, which already has its history storage.
I don't believe the other history client callbacks are useful, they duplicate other signals in WebKitWebView such as resource-load-started and decide-policy. (That epiphany has a history at all is proof)

Which also means that having visited links just work is problematic, because my simple design relies on the app to do the storage. We would need to reimplement the history database using sqlite in webkitgtk, and I'd like to avoid that, at least in the initial implementation.

I believe this API is as simple as it can get, and would allow epiphany to finally have visited links support with minimal changes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.