[Webkit-unassigned] [Bug 128372] [CSS Grid Layout] handle undefined RemainingSpace in computeUsedBreadthOfGridTracks algorithm
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Feb 18 11:55:24 PST 2014
https://bugs.webkit.org/show_bug.cgi?id=128372
Dave Hyatt <hyatt at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #223649|review? |review+
Flag| |
--- Comment #2 from Dave Hyatt <hyatt at apple.com> 2014-02-18 11:52:36 PST ---
(From update of attachment 223649)
View in context: https://bugs.webkit.org/attachment.cgi?id=223649&action=review
r=me, although concerned about the one function I called out.
> Source/WebCore/rendering/RenderGrid.cpp:269
> +static bool gridElementIsShrinkToFit(const RenderStyle& style)
> +{
> + return style.isFloating() || style.position() == AbsolutePosition;
> +}
This looks suspicious to me. Are you wanting to catch everybody that just sizes intrinsically? This is not enough if so.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list