[Webkit-unassigned] [Bug 25571] DOM range methods setStartBefore/setEndAfter fails on detached elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25571





--- Comment #25 from Bhanu <b.rout at samsung.com>  2014-02-18 05:24:57 PST ---
After cross-verifying, I found this has been already handled in checkNodeWOffset() which is invoked from setStart/setEnd.

> > Source/WebCore/dom/Range.cpp:1213
> >      setStart(refNode->parentNode(), refNode->nodeIndex() + 1, ec);
> 
> setStart must throw InvalidNodeTypeError when refNode is doc type but it doesn't.
> So this effectively breaks setStartAfter in that regard as well.

I will have a detailed changelog with the spec revision I am following.
.
> We should mention that in the change log as my point was that the spec could change in the future, not that it may have already changed.

> Ah I see. We should probably mention that in the change log as a per-function inline comment.
> 
> See http://www.webkit.org/coding/contributing.html#changelogs for an example of a well written change log.

Let me know if I need to take care of anything in particular to this issue and the new spec.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.