[Webkit-unassigned] [Bug 128912] New: Move back primary header includes next to config.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128912

           Summary: Move back primary header includes next to config.h
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ossy at webkit.org
                CC: ossy at webkit.org


http://trac.webkit.org/changeset/163760 " Never include *Inlines.h files in interface 
headers, and never include *Inlines.h when you could include Operations.h instead"

This changeset moved many primary header inclusion after the #if ENABLE(...) guard
without any profit and added zillion webkit style violations pointlessly.

The discussion started about it in the original bug report:
https://bugs.webkit.org/show_bug.cgi?id=128505#c26

original code was
------------------
#include "config.h"
#include "Blah.h"

#if ENABLE(...)

new code is:
-------------
#include "config.h"

#if ENABLE(...)

#include "Blah.h"

--------------------------------------------------------------------------------------

It was a false presumption if this kind of change fixed the EFL build,
because ENABLE(JIT) and ENABLE(DFG_JIT) are always true on EFL.

Additionally almost all of these headers are guarded properly, 
we really don't need one more guard for the include.

I'm going to revert this unrelated noise.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.