[Webkit-unassigned] [Bug 128877] Move document life time management from TreeScope to Document

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128877


Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #224312|review?                     |review+
               Flag|                            |




--- Comment #5 from Andreas Kling <akling at apple.com>  2014-02-16 11:27:37 PST ---
(From update of attachment 224312)
View in context: https://bugs.webkit.org/attachment.cgi?id=224312&action=review

r=me. This feels like a good step forward.

> Source/WebCore/dom/Document.h:1714
> -    , m_treeScope(document ? document : &TreeScope::noDocumentInstance())
> +    , m_treeScope(document)

Nice!

> Source/WebCore/dom/DocumentOrderedMap.cpp:94
> +    UNUSED_PARAM(treeScope);
>      ASSERT_WITH_SECURITY_IMPLICATION(element.isInTreeScope());
>      ASSERT_WITH_SECURITY_IMPLICATION(treeScope.rootNode()->containsIncludingShadowDOM(&element));

Oh, there's no ASSERT_WITH_SECURITY_IMPLICATION_UNUSED so we have to use UNUSED_PARAM.
Not ideal but whatever.

> Source/WebCore/dom/Node.cpp:306
>      if (hasRareData())
>          clearRareData();

This is also done by ~ShadowRoot which no longer seems necessary.

> Source/WebCore/dom/TreeScope.h:98
> +    ContainerNode* rootNode() const { return &m_rootNode; }

I suppose we can make this return ContainerNode& later on.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.