[Webkit-unassigned] [Bug 128813] [GTK] Minibrowser: Add shortcut to open Web Inspector

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 14 14:28:01 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=128813





--- Comment #5 from Diego Pino <dpino at igalia.com>  2014-02-14 14:25:15 PST ---
(From update of attachment 224210)
View in context: https://bugs.webkit.org/attachment.cgi?id=224210&action=review

>> Tools/ChangeLog:8
>> +        Added shortcut Ctrl+i for toggling Web Inspector.
> 
> Is this shortcut used by some other port? Is it used in GtkLauncher?

Yes, Minibrowser EFL uses Ctrl+i to open the Web Inspector (Tools/MiniBrowser/efl/main.c:444):

else if (!strcmp(ev->key, "i") && ctrlPressed) {
        info("Show Inspector (Ctrl+i) was pressed.");
        ewk_view_inspector_show(ewk_view);
    }

GtkLauncher doesn't implement this shortcut.

>> Tools/MiniBrowser/gtk/BrowserWindow.c:503
>> +static gboolean toggleWebInspector(GObject *gObject, gpointer user_data)
> 
> Don't use camel case for attributes in this file. Also I guess you can use here BrowserWindow directly instead of GObject as you're using G_CALLBACK().

Ok

>> Tools/MiniBrowser/gtk/BrowserWindow.c:511
>> +    height = webkit_web_inspector_get_attached_height(inspectorWindow);
> 
> If you're going to use the variable just once, better do not define it and directly use the return value from the function.
> 
> In any case I don't think the logic is correct. If the inspector is shown in a dettached mode, the height will be 0 so you won't close it.

Yes, that's correct. Finally I implemented visibility of the window registering to signals "open-window" and "closed" to know when the window has been detached but it's still opened and when the window was closed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list