[Webkit-unassigned] [Bug 128840] ASSERT(isValidAllocation(bytes)) when ObjC API creates custom errors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128840


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joepeck at webkit.org




--- Comment #1 from Joseph Pecoraro <joepeck at webkit.org>  2014-02-14 13:48:01 PST ---
There are a number of create calls throughout the ObjC API. They will all need to be audited:

    shell> ack 'create.*?Error' API/*.mm
    API/JSValue.mm
    784:        *exception = toRef(JSC::createTypeError(toJS(context), "Cannot convert primitive to NSArray"));
    800:        *exception = toRef(JSC::createTypeError(toJS(context), "Cannot convert primitive to NSDictionary"));

    API/ObjCCallbackFunction.mm
    132:        *exception = toRef(JSC::createTypeError(toJS(contextRef), "Argument does not match Objective-C Class"));
    456:    // (2) We're calling some JSC internals that require us to be on the 'inside' - e.g. createTypeError.
    499:        *exception = toRef(JSC::createTypeError(toJS(contextRef), "Objective-C blocks called as constructors must return an object."));
    565:            *exception = toRef(JSC::createTypeError(toJS(contextRef), "self type check failed for Objective-C instance method"));
    575:            *exception = toRef(JSC::createTypeError(toJS(contextRef), "self type check failed for Objective-C instance method"));

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.