[Webkit-unassigned] [Bug 123716] SVG rectangle with filter will not render

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123716


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #224112|review?                     |review-
               Flag|                            |




--- Comment #10 from Simon Fraser (smfr) <simon.fraser at apple.com>  2014-02-14 11:32:43 PST ---
(From update of attachment 224112)
View in context: https://bugs.webkit.org/attachment.cgi?id=224112&action=review

> Source/WebCore/platform/graphics/filters/FilterEffect.cpp:41
> +static const float kMaxFilterArea = 8192 * 8192;

You may have to reduce this given the timing out tests.

> Source/WebCore/platform/graphics/filters/FilterEffect.cpp:67
> +float FilterEffect::maxFilterLength()

Would be nice if you renamed the functions too to include "dimension"

> Source/WebCore/platform/graphics/filters/FilterEffect.h:62
> +    static bool isFilterSizeValid(const IntRect&);
> +    static bool isFilterSizeValid(const FloatRect&);

We implicitly convert IntRect -> FloatRect so you don't need both.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.