[Webkit-unassigned] [Bug 127324] REGRESSION (r160259?): text-combine glyphs are not rendered

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127324





--- Comment #7 from Yuki Sekiguchi <yuki.sekiguchi at access-company.com>  2014-02-13 20:16:06 PST ---
(In reply to comment #5)
> (From update of attachment 223322 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=223322&action=review
> 
> > Source/WebCore/rendering/RenderCombineText.cpp:54
> > +void RenderCombineText::setTextInternal(const String& text, const bool replace)
> 
> No need for const in front of bool.

Fixed.

> > Source/WebCore/rendering/RenderCombineText.h:52
> > +    virtual void setTextInternal(const String&, const bool repace = false) override;
> 
> Same here. Also, you have a typo "replace" not "repace"

Fixed.

> > Source/WebCore/rendering/RenderText.cpp:1027
> > +void RenderText::setTextInternal(const String& text, const bool replace)
> 
> And here.

Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.