[Webkit-unassigned] [Bug 126855] Web Inspector: scope chain details sidebar doesn't update values modified via console

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 13 19:19:33 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=126855


Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #224125|review?                     |review-
               Flag|                            |




--- Comment #3 from Timothy Hatcher <timothy at apple.com>  2014-02-13 19:16:48 PST ---
(From update of attachment 224125)
View in context: https://bugs.webkit.org/attachment.cgi?id=224125&action=review

Thanks for looking into this!

> Source/WebInspectorUI/UserInterface/JavaScriptLogViewController.js:228
> +            WebInspector.scopeChainDetailsSidebarPanel.needsRefresh();

This would be better as an event that the sidebar observes. Having this low-level view class directly call a higher-level class is a layering violation.

RuntimeManager would be a good place to fire the event that the sidebar observes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list