[Webkit-unassigned] [Bug 127324] REGRESSION (r160259?): text-combine glyphs are not rendered

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127324


Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #223322|review?                     |review+
               Flag|                            |




--- Comment #5 from Dean Jackson <dino at apple.com>  2014-02-13 17:19:14 PST ---
(From update of attachment 223322)
View in context: https://bugs.webkit.org/attachment.cgi?id=223322&action=review

> Source/WebCore/rendering/RenderCombineText.cpp:54
> +void RenderCombineText::setTextInternal(const String& text, const bool replace)

No need for const in front of bool.

> Source/WebCore/rendering/RenderCombineText.h:52
> +    virtual void setTextInternal(const String&, const bool repace = false) override;

Same here. Also, you have a typo "replace" not "repace"

> Source/WebCore/rendering/RenderText.cpp:1027
> +void RenderText::setTextInternal(const String& text, const bool replace)

And here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.