[Webkit-unassigned] [Bug 123716] SVG rectangle with filter will not render

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123716





--- Comment #6 from Adenilson Cavalcanti Silva <savagobr at yahoo.com>  2014-02-13 14:34:45 PST ---
Thanks for the review, I will comment inline.

> > Source/WebCore/ChangeLog:8
> > +        A filtered SVG element with width or length bigger than 5.000
> 
> You should write this as 5000 or 5,000. 5.000 sounds like decimal 5.
> 
Fixed.

> > Source/WebCore/ChangeLog:10
> > +	(counting the margin/border) will fail to render. This patch will
> > +	instead test against the total element area.
> 
> Weird indentation
> 
Fixed.

> > Source/WebCore/platform/graphics/filters/FilterEffect.cpp:42
> > +static const float kMaxFilterLength = 8192;
> 
> Length is ambiguous here. Length of what? Dimension would be better.
> 
Fixed.

> > Source/WebCore/platform/graphics/filters/FilterEffect.cpp:84
> > +
> 
> Extra blank line.
Fixed.

> 
> > Source/WebCore/platform/graphics/filters/FilterEffect.h:62
> > +    static bool isFilterSizeValid(const IntRect&);
> > +    static bool isFilterSizeValid(const FloatRect&);
> 
> Are both really necessary?

Yep, FilterEffectRenderer.cpp uses FloatRect and FilterEffect used IntRect.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.