[Webkit-unassigned] [Bug 25571] DOM range methods setStartBefore/setEndAfter fails on detached elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25571





--- Comment #18 from Ryosuke Niwa <rniwa at webkit.org>  2014-02-13 11:43:26 PST ---
(From update of attachment 222969)
View in context: https://bugs.webkit.org/attachment.cgi?id=222969&action=review

> Source/WebCore/ChangeLog:8
> +        this requirement. Chromium code has the same change to fix the issue.

Please refer to the blink change & the original author since you're presumably making this change after having looked at their code change.

> Source/WebCore/ChangeLog:11
> +        Reviewed by NOBODY (OOPS!).

This line should appear before the long description but after the bug url.

> Source/WebCore/dom/Range.cpp:1189
> -    // INVALID_NODE_TYPE_ERR: Raised if the root container of refNode is not an
> -    // Attr, Document, DocumentFragment or ShadowRoot node, or part of a SVG shadow DOM tree,
> +    // INVALID_NODE_TYPE_ERR: Raised if parent of refNode is null or the root container of refNode 
> +    // is not an Attr, Document, DocumentFragment or ShadowRoot node, or part of a SVG shadow DOM tree, Element node

I'd prefer deleting this comment altogether instead of updating it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.