[Webkit-unassigned] [Bug 128751] New: [check-webkit-style] False positive when using the ternary operators with multiple lines.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 13 11:35:40 PST 2014
https://bugs.webkit.org/show_bug.cgi?id=128751
Summary: [check-webkit-style] False positive when using the
ternary operators with multiple lines.
Product: WebKit
Version: 528+ (Nightly build)
Platform: Unspecified
OS/Version: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: Tools / Tests
AssignedTo: webkit-unassigned at lists.webkit.org
ReportedBy: jfernandez at igalia.com
This scenario triggers the following style issue:
* Wrong number of spaces before statement. (expected: 24) [whitespace/indent] [4]
For what could understand, the use of the ternary operator in multiple lines makes the style checker to trigger indent issues in different lines. These lines in the CSSParser.cpp file are the root cause of the problem:
RefPtr<CSSPrimitiveValue> amount = arg->id == CSSValueAuto ?
cssValuePool().createIdentifierValue(CSSValueAuto) :
createPrimitiveNumericValue(arg);
I'm not really sure whether such syntax is correct or not. If it's correct, this is a false positive, otherwise this bug should be resolved by adding a new style check to prevent that way of using the ternary operator.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list