[Webkit-unassigned] [Bug 128211] &HWND should not be used as OLE_HANDLE*

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 11 13:07:32 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=128211


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #223891|review?                     |review+
               Flag|                            |




--- Comment #9 from Brent Fulgham <bfulgham at webkit.org>  2014-02-11 13:04:45 PST ---
(From update of attachment 223891)
View in context: https://bugs.webkit.org/attachment.cgi?id=223891&action=review

Looks good, but I'd like the one C-cast to be changed to a C++ cast, please!  :-)

> Source/WebKit/win/WebCoreSupport/WebContextMenuClient.cpp:66
> +    OLE_HANDLE nativeMenu = (OLE_HANDLE)menu->platformContextMenu();

reinterpret_cast<OLE_HANDLE>

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list