[Webkit-unassigned] [Bug 128532] [MSE] Move PublicURLManager shutdown logic so ActiveDOMObjects associated with public URLs won't leak.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128532


Jer Noble <jer.noble at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #223850|review?                     |review+
               Flag|                            |




--- Comment #6 from Jer Noble <jer.noble at apple.com>  2014-02-11 08:27:55 PST ---
(From update of attachment 223850)
View in context: https://bugs.webkit.org/attachment.cgi?id=223850&action=review

> Source/WebCore/ChangeLog:6
> +        [MSE] Move PublicURLManager shutdown logic so ActiveDOMObjects associated with public URLs won't leak.
> +        https://bugs.webkit.org/show_bug.cgi?id=128532
> +
> +        Reviewed by NOBODY (OOPS!).

I was really confused until I read the bug report.  It would be nice to add some text to the ChangeLog which says what this fix does.  Something like:

This fixes a leak of DOM objects by breaking the circular reference between Document, PublicURLManager, and MediaSource. Instead of clearing PublicURLManager at destruction-time, which is delayed indefinitely because of the circular reference, clear the PublicURLManager during ActiveDOMObject::stop().

> Source/WebCore/html/PublicURLManager.h:48
> -    static OwnPtr<PublicURLManager> create() { return adoptPtr(new PublicURLManager); }
> +    static PassOwnPtr<PublicURLManager> create(ScriptExecutionContext*);

We should fix this function to return a std::unique_ptr<>, but we don't have to do it in this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.