[Webkit-unassigned] [Bug 128587] New: Frame::rectForSelection shouldn't instantiate FrameSelection

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 11 01:22:24 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=128587

           Summary: Frame::rectForSelection shouldn't instantiate
                    FrameSelection
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML Editing
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: darin at apple.com, ap at webkit.org, mitz at webkit.org,
                    justin.garcia at apple.com, enrica at apple.com,
                    psolanki at apple.com


Right now, Frame::rectForSelection instantiates a FrameSelection in order to compute the absolute caret bounds of start and end points.

We're trying to contain the side-effects of FrameSelection::setSelection with suppressSelectionNotifications and restoreSelectionNotifications on WebEditorClient,
as well as suppressCloseTyping and restoreCloseTyping on FrameSelection but selectionchange event still fires and it could change the focus,

Because it uses FrameSelection::setSelection on both start and end points, it erroneously fires selectionchange events and closes the open typing command.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list