[Webkit-unassigned] [Bug 128453] [GStreamer] High playback rate causes crash

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128453


Philippe Normand <pnormand at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #223563|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Philippe Normand <pnormand at igalia.com>  2014-02-09 20:41:03 PST ---
(From update of attachment 223563)
View in context: https://bugs.webkit.org/attachment.cgi?id=223563&action=review

> LayoutTests/ChangeLog:3
> +        [GStreamer] High playback rate causes crash

Have you investigated that crash? Might be worth a GStreamer bug report.

> LayoutTests/media/video-extreme-playbackrate-crash.html:15
> +                video.playbackRate = 10000000;

The spec (afaik) doesn't define the range of valid playbackRate values. So I don't think we should have a test for this, what do you think Eric?

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:866
> +    // Higher rate causes crash.

This is quite high indeed... I don't think these values make sense from a user point of view, limiting to (-10, 10) would perhaps be a more reasonable thing to do?

And please use clampTo() from MathExtras.h

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.