[Webkit-unassigned] [Bug 128454] New: ImageDiff compile fails when compiled with libc++

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128454

           Summary: ImageDiff compile fails when compiled with libc++
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: Minor
          Priority: P2
         Component: WebKit Gtk
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: zimbabao at gmail.com
                CC: zandobersek at gmail.com


repro steps: Compile webkit using libc++.

Observation: Following compile errors.

Resolution: include cstdlib in ImageDiff.cpp.

WebKit/Tools/ImageDiff/gtk/ImageDiff.cpp:103:61: error: use of undeclared identifier 'malloc'; did you mean 'g_malloc'?
    unsigned char* diffBuffer = static_cast<unsigned char*>(malloc(width * height));
                                                            ^~~~~~
                                                            g_malloc
webkit_deps/include/glib-2.0/glib/gmem.h:78:10: note: 'g_malloc' declared here
gpointer g_malloc         (gsize         n_bytes) G_GNUC_MALLOC G_GNUC_ALLOC_SIZE(1);
         ^
WebKit/Tools/ImageDiff/gtk/ImageDiff.cpp:147:5: error: use of undeclared identifier 'free'
    free(diffBuffer);
    ^
WebKit/Tools/ImageDiff/gtk/ImageDiff.cpp:207:30: error: use of undeclared identifier 'strtol'
            long imageSize = strtol(tokens[1], 0, 10);
                             ^
3 errors generated.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.