[Webkit-unassigned] [Bug 128449] [GTK] Build break in WebKitWebViewBase.cpp::webkitWebViewBaseCreateWebPage

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 8 00:01:32 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=128449


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #223557|review?                     |review-
               Flag|                            |




--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-02-07 23:58:50 PST ---
(From update of attachment 223557)
View in context: https://bugs.webkit.org/attachment.cgi?id=223557&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:957
> +    webPageConfiguration.relatedPage = webkitWebViewBaseGetPage(webkitWebViewBase);

This is not correct, you are using the page you are creating as the related page. You should not initialize the related page (it's already null at this point), is currently unimplemented in gtk+ port.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list