[Webkit-unassigned] [Bug 123170] Keyframe animations do multiple style recalcs before starting

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123170





--- Comment #13 from Ralph T <ralpht+bugs at gmail.com>  2014-02-07 10:07:31 PST ---
Apologies for not following up. I tested this patch on mac and manually went through all of the animations tests and validated that they looked the same before and after (they all have the expected results with the patch).

I wanted to prevent the compositor from calling GraphicsLayerClient::notifyAnimationStarted (break it so it never gets called) and validate that when an accelerated animation and an unaccelerated animation are discovered in the same style recalc that the unaccelerated one doesn't start -- I think this would satisfy Simon's concerns about accelerated vs. unaccelerated start times being coordinated. I did do this test on my own port, which has a compositor that supports accelerated animations in the same way mac does and it was fine (the unaccelerated animation didn't start).

I'll try to build against trunk on mac today and perform the above test. We could make this behavior testable by letting internals enable/disable the compositor calling nofifyAnimationStarted (or making it a no-op internally). Would this be a good contribution?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.