[Webkit-unassigned] [Bug 128115] [Win] LLINT is not working.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128115


Mark Lam <mark.lam at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #223456|review?                     |review+
               Flag|                            |




--- Comment #29 from Mark Lam <mark.lam at apple.com>  2014-02-07 09:53:09 PST ---
(From update of attachment 223456)
View in context: https://bugs.webkit.org/attachment.cgi?id=223456&action=review

Thanks for your work.  I did a benchmark run on Mac x86_64 to make sure that the LLINT changes did not regress performance.  There were no regressions.

r=me with llint_crash updated to not require a return value.

> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1448
> +extern "C" SlowPathReturnType llint_crash()
> +{
> +    CRASH();
> +    return encodeResult(0, 0);

nit: you can get rid of this return by changing the prototype to: extern "C” NO_RETURN_DUE_TO_CRASH void llint_crash().  Sorry I didn’t catch this yesterday.

> Source/JavaScriptCore/llint/LLIntSlowPaths.h:131
> +extern "C" SlowPathReturnType llint_crash() WTF_INTERNAL;

ditto.  Change to: extern "C” NO_RETURN_DUE_TO_CRASH void llint_crash() WTF_INTERNAL;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.