[Webkit-unassigned] [Bug 127990] [CSS Grid Layout] Rename named areas property

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=127990





--- Comment #3 from Sergio Villar Senin <svillar at igalia.com>  2014-02-07 01:20:21 PST ---
(From update of attachment 223401)
View in context: https://bugs.webkit.org/attachment.cgi?id=223401&action=review

Looks good, added some nits.

> Source/WebCore/css/CSSGridTemplateAreasValue.cpp:3
> + * Copyright (C) 2013 Igalia S.L.

You might want to add 2014 here

> Source/WebCore/css/CSSGridTemplateAreasValue.h:3
> + * Copyright (C) 2013 Igalia S.L.

ditto.

> LayoutTests/fast/css-grid-layout/grid-item-area-get-set.html:12
>                             "thirdArea thirdArea";

Add spaces here to align both strings

> LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html:12
>                             "thirdArea thirdArea";

ditto.

> LayoutTests/fast/css-grid-layout/grid-item-named-grid-area-resolution.html:16
> +    -webkit-grid-template-areas: "first second third"

ditto

> LayoutTests/fast/css-grid-layout/grid-item-named-grid-area-resolution.html:22
>                             "fourth fourth third";

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.