[Webkit-unassigned] [Bug 98931] [GTK] Enable touch features

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 6 15:39:06 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=98931





--- Comment #31 from Carlos Garnacho <carlosg at gnome.org>  2014-02-06 15:36:23 PST ---
I applied all suggestions, just a few comments below

(In reply to comment #27)
> > Source/WebCore/bindings/gobject/GNUmakefile.am:266
> > +	DerivedSources/webkitdom/WebKitDOMTouch.cpp \
> > +	DerivedSources/webkitdom/WebKitDOMTouchPrivate.h \
> 
> I wonder what happens with this API in wk1, I guess it simply won't work.

Yes. I did the bare minimum to have things compiling in WK1. That said, it should work
just like always wrt touch events, just knowing about pointer emulation.

> > Tools/DumpRenderTree/gtk/EventSender.cpp:917
> > +    return JSValueMakeUndefined(context);
> 
> We don't need to do anything here?

IIRC I had to add that so WK1 compiled after I added the touch IDLs to build, shouldn't be ever triggered.

(In reply to comment #28)
> > Source/WebCore/platform/gtk/GtkTouchContextHelper.h:41
> > +    GtkTouchContextHelper() { };
> 
> Can't this constructor go as Zan says?
> 

I tried and no dice, WTF_MAKE_NONCOPYABLE seems to like having a constructor

> > Source/WebKit2/ChangeLog:31
> > +        * GNUmakefile.list.am:
> > +        * PlatformGTK.cmake:
> > +        * Shared/gtk/NativeWebTouchEventGtk.cpp:
> > +        * Shared/NativeWebTouchEvent.h:
> > +        (WebKit::NativeWebTouchEvent::nativeEvent):
> > +        (WebKit::NativeWebTouchEvent::touchContext): Add GTK+ implementation of NativeWebTouchEvent
> > +        * Shared/gtk/WebEventFactory.cpp:
> > +        (WebKit::touchPhaseFromEvents):
> > +        (WebKit::WebEventFactory::createWebTouchEvent): Add methods to generate NativeWebTouchEvents out
> > +        of GdkEventTouch events, a GtkTouchContextHelper object is used to hold information about all current
> > +        touches, in order to build information about all individual touchpoints.
> > +        * Shared/gtk/WebEventFactory.h:
> > +        * UIProcess/API/gtk/PageClientImpl.cpp:
> > +        (WebKit::PageClientImpl::doneWithTouchEvent): Implement pointer emulation if the pointer emulating
> > +        touch was unhandled.
> > +        * UIProcess/API/gtk/PageClientImpl.h:
> > +        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
> > +        (webkitWebViewBaseRealize): Listen for touch events
> > +        (webkitWebViewBaseTouchEvent):
> > +        (webkit_web_view_base_class_init): Add implementation for the touch_events() handler.
> 
> I think this could be a bit more descriptive.

I tried being more verbose there :), but actually not a lot happens there, just plenty of data structure wrapping.

> 
> > Source/WebKit2/PlatformGTK.cmake:570
> > +        Shared/WebTouchEvent.cpp
> 
> Incorrectly sorted.
> 
> Also, Shared/WebPlatformTouchPoint.cpp is missing here, otherwise, it won't link.

Good catch :)

> 
> If both EFL and GTK have now ENABLE_TOUCH_EVENTS ON we could remove this line and the one for EFL.

Yup, did that on WebKitFeatures.cmake

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list