[Webkit-unassigned] [Bug 128115] [Win] LLINT is not working.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 5 13:32:28 PST 2014
https://bugs.webkit.org/show_bug.cgi?id=128115
--- Comment #19 from Mark Lam <mark.lam at apple.com> 2014-02-05 13:29:47 PST ---
(From update of attachment 223229)
View in context: https://bugs.webkit.org/attachment.cgi?id=223229&action=review
>> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:-699
>> - dispatch(0)
>
> This is not functionally equivalent, and hence is a bug. _llint_function_for_call_prologue expects to fall thru into .functionForCallBegin. Now it doesn’t.
>
> Fix it by removing the .functionCallBegin label (which isn’t used locally). I guess will have to replicate this code. I’ll do some benchmarking after this to make sure that there’s no perf impact here.
To clarify: I meant you should remove the .functionForCallBegin label, but leave the other 2 lines in. Same for _llint_function_for_construct_prologue below.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list