[Webkit-unassigned] [Bug 128211] New: &HWND should not be used as OLE_HANDLE*

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128211

           Summary: &HWND should not be used as OLE_HANDLE*
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Windows 8
            Status: NEW
          Severity: Blocker
          Priority: P2
         Component: WebKit Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: alex.christensen at flexsim.com
                CC: bfulgham at webkit.org, roger_fong at apple.com


An OLE_HANDLE is a UINT, which is always a 32-bit integer.  A HWND is a HWND__*, which is 32-bits for Win32 and 64-bits for Win64.  Casting between the two seems to be ok in most cases, and they're often used interchangeably without a problem.  There are several functions in WebKit that take an OLE_HANDLE* to put something into, and we're giving it a casted pointer to a HWND.  This does not cause a problem on Win32 because they're equivalent, but it puts a 32-bit integer at the beginning of a 64-bit integer with my Win64 builds, which causes some crashes sometimes.  This fixes those crashes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.