[Webkit-unassigned] [Bug 128115] [Win] LLINT is not working.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128115





--- Comment #11 from peavo at outlook.com  2014-02-04 08:56:50 PST ---
(In reply to comment #9)
> (From update of attachment 223031 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=223031&action=review
> 
> Good work.  I tried applying your 2nd patch and doing a Windows build, but the build failed in the generation of LowLevelInterpreterWin.asm.  Can you please address the feedback, rebase to ToT (if you haven't already), and retest to make sure that the patch does build for Windows?  Also make sure the EWS bots are green.  I'll take another look after that.  Thanks.

Thanks for looking into this :) I updated the patch according to your comments.

> 
> > Source/JavaScriptCore/offlineasm/asm.rb:211
> > +        putsProcEndIfNeeded
> 
> Is this really needed?  I would think that local labels should not exists out of the bounds of a PROC and ENDP.  If this indeed needed, can you provide details of an example where it's needed and why?

Good you picked up on this. I removed this call, and then had to make a local label global (opPutByIdSlow), in order for others to see it, since it then was visible only inside the PROC.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.