[Webkit-unassigned] [Bug 139179] HTMLSelectElement add() should support index as second argument

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139179

--- Comment #47 from Darin Adler <darin at apple.com> ---
Comment on attachment 243839
  --> https://bugs.webkit.org/attachment.cgi?id=243839
Patch-Updated-Review6

View in context: https://bugs.webkit.org/attachment.cgi?id=243839&action=review

> Source/WebCore/html/HTMLOptionsCollection.cpp:39
> +void HTMLOptionsCollection::add(HTMLElement* element, HTMLElement* before, ExceptionCode& ec)

Would be nice to call the argument beforeElement like we do in the header file.

> Source/WebCore/html/HTMLOptionsCollection.idl:33
> +    [RaisesException] void add([Default=Undefined] optional HTMLOptionElement option, unsigned long index);

This should be long, not unsigned long, to match HTMLSelectElement.idl and the implementation. Unless that’s all some kind of mistake?

> Source/WebCore/html/HTMLSelectElement.idl:45
>      [ObjCLegacyUnnamedParameters, RaisesException] void add([Default=Undefined] optional HTMLElement element,
> -                            [Default=Undefined] optional HTMLElement before);
> +                            [Default=Undefined] optional HTMLElement? before);

It would be nice to fix the indentation here, or put this all on one long line.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150101/60483aa2/attachment-0002.html>