[Webkit-unassigned] [Bug 139946] New: Typo in StyleResolveTree.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 25 09:41:31 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=139946

            Bug ID: 139946
           Summary: Typo in StyleResolveTree.cpp
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: iOS
                OS: Unspecified
            Status: NEW
          Severity: Minor
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mkisilev at yandex-team.ru
                CC: dbates at webkit.org

In constructor of class CheckForVisibilityChangeOnRecalcStyle there is a line:
, m_previousImplicitVisibility(WKObservingContentChanges() && WKContentChange() != WKContentVisibilityChange ? elementImplicitVisibility(element) : VISIBLE)

Calling WKContentChange() will produce enum of type WKContentChange whose value will alwayse be not equal to WKContentVisibilityChange.
Probably author wanted to call WKObservedContentChange() instead of WKContentChange().

Line should be replace with:
, m_previousImplicitVisibility(WKObservingContentChanges() && WKObservedContentChange() != WKContentVisibilityChange ? elementImplicitVisibility(element) : VISIBLE)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141225/5993d067/attachment-0002.html>


More information about the webkit-unassigned mailing list