[Webkit-unassigned] [Bug 139862] New: execDeleteCommand() does not update spellchecker sometimes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 22 07:53:54 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=139862

            Bug ID: 139862
           Summary: execDeleteCommand() does not update spellchecker
                    sometimes
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML Editing
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: g.czajkowski at samsung.com

The following tests are failing:

LayoutTests/editing/spelling/editing-multiple-words-with-markers.html
LayoutTests/editing/spelling/grammar-edit-word.html

There are three issues:

1. In one task in TypingCommand::deleteKeyPressed we are doing two selection changes:

deleteSelection(selectionToDelete, m_smartDelete);
   calls respondToChangedSelection() and editorUIUpdateTimer.startOneShot(0)

typingAddedToOpenCommand(DeleteKey); 
   calls respondToChangedSelection() but editorUIUpdateTimer is still active and we do an early return and do not notify spellchecker about this selection change.

Invoking updateEditorUINowIfScheduled() does not help after applying command as we already lost one selection change.

2. Internals::hasGrammarMarker() does not invoke updateEditorUINowIfScheduled()

3. After non-editing selection changes the tests should invoke internals.updateEditorUINowIfScheduled()

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141222/e53c4f03/attachment-0002.html>


More information about the webkit-unassigned mailing list