[Webkit-unassigned] [Bug 138831] [GTK] Use GMainLoopSource in WebKitTestRunner

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138831

--- Comment #11 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #10)
> Comment on attachment 241782 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=241782&action=review
> 
> > Tools/WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:52
> > +    m_waitToDumpWatchdogTimer.scheduleAfterDelay("[WTR] waitToDumpWatchdogTimerCallback", [this] { waitToDumpWatchdogTimerFired(); },
> > +        std::chrono::duration_cast<std::chrono::microseconds>(std::chrono::duration<double>(waitToDumpWatchdogTimerInterval)));
> 
> waitToDumpWatchdogTimerInterval is 30, for 30 seconds. Is the cast to
> microseconds the right one here?

Yes, the scheduleAfterDelay() version that receives the delay in microseconds creates a glib source using microseconds. For this particular case we could use milliseconds, but we moved all sources using a double value to microseconds to avoid truncations (we had cases in which timers were scheduled immediately because the conversion to milliseconds was 0, see bug #137782).

> > Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp:71
> >      gtk_main();
> 
> Ditto, why microseconds?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141216/72e09f58/attachment-0002.html>