[Webkit-unassigned] [Bug 30322] WebKit level persistent caching

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30322

--- Comment #59 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 241955
  --> https://bugs.webkit.org/attachment.cgi?id=241955
fix LOG_DISABLED build

View in context: https://bugs.webkit.org/attachment.cgi?id=241955&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:150
> +            LOG(NetworkCache, "(NetworkProcess) varying header mistmatch\n");

Typo: mistmatch => mismatch?

> Source/WebKit2/NetworkProcess/cache/NetworkCache.h:36
> +#include <wtf/BloomFilter.h>
> +#include <wtf/Deque.h>
> +#include <wtf/HashSet.h>

Are these includes still needed?

> Source/WebKit2/NetworkProcess/cache/NetworkCache.h:75
> +    String fileNameForURL(const WebCore::URL&);
> +    String directoryPathForCachePartition(const String&);
> +    String filePathForRequest(const WebCore::ResourceRequest&);

Can these be removed? It looks like they were moved to NetworkCacheStorage and no longer have an imp in this class.

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:36
> +#include <wtf/RetainPtr.h>

Is this include still needed?

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:172
> +    case IOChannelType::Read:
> +        oflag = O_RDONLY | O_NONBLOCK;
> +        mode = 0;
> +    }

I would still expect a "break;" here anyways to avoid possible compiler warnings.

> Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm:68
> +            NSURLCache *URLCache = [[NSURLCache alloc] initWithMemoryCapacity:0 diskCapacity:0 diskPath:nil];

Possible leak / analyzer warning. You could adopt into a RetainPtr (see other cases use of adoptNS). This object will probably be around forever, but we should exercise good memory management.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141215/a233f737/attachment-0002.html>