[Webkit-unassigned] [Bug 138831] [GTK] Use GMainLoopSource in WebKitTestRunner

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138831

--- Comment #10 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 241782
  --> https://bugs.webkit.org/attachment.cgi?id=241782
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=241782&action=review

> Tools/WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:52
> +    m_waitToDumpWatchdogTimer.scheduleAfterDelay("[WTR] waitToDumpWatchdogTimerCallback", [this] { waitToDumpWatchdogTimerFired(); },
> +        std::chrono::duration_cast<std::chrono::microseconds>(std::chrono::duration<double>(waitToDumpWatchdogTimerInterval)));

waitToDumpWatchdogTimerInterval is 30, for 30 seconds. Is the cast to microseconds the right one here?

> Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp:71
>      gtk_main();

Ditto, why microseconds?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141215/2ac84efa/attachment-0002.html>