[Webkit-unassigned] [Bug 132269] Document.contentType implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=132269

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #243120|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #39 from Darin Adler <darin at apple.com> ---
Comment on attachment 243120
  --> https://bugs.webkit.org/attachment.cgi?id=243120
Patch v8

View in context: https://bugs.webkit.org/attachment.cgi?id=243120&action=review

> Source/WebCore/dom/Document.h:469
> +    String contentType() const; // DOM 4 document.contentType

I don’t think this comment is helpful. We don’t want to comment every function with the standard it comes from.

> Source/WebCore/dom/Document.idl:108
> +    // DOM 4

I’ve heard there is no standard any more named “DOM 4”, so we might just want to leave this comment out.

> Source/WebCore/loader/DocumentLoader.h:121
> +        const String& mimeType() const;

Please consider changing the name as I requested. I gave my rationale in a comment in the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141215/b8c85c05/attachment-0002.html>