[Webkit-unassigned] [Bug 139179] HTMLSelectElement add() should support index as second argument

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139179

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #243283|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #9 from Darin Adler <darin at apple.com> ---
Comment on attachment 243283
  --> https://bugs.webkit.org/attachment.cgi?id=243283
Patch-Updated-Review1

View in context: https://bugs.webkit.org/attachment.cgi?id=243283&action=review

review- because of the build failures on Mac and GTK

> Source/WebCore/html/HTMLSelectElement.idl:46
> +    [RaisesException] void add(HTMLElement element, long before);

GTK and Mac bindings are still failing to build. To work around it, this line needs to go inside a #if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT block.

> LayoutTests/fast/dom/HTMLSelectElement/select-add.html:44
> +mySelect.add(new Option("X", "Y", false, false), -100);

We should cover the following integers: 2147483647, 2147483648, -2147483648, -2147483649, since these are the edge cases for converting floating point numbers to integers.

> LayoutTests/fast/dom/HTMLSelectElement/select-add.html:52
> +mySelect.add(new Option("X", "Y", false, false), "1");

Besides "1", we should cover false and true, which should convert into 0 and 1 when passed as an integer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141215/b1696e4d/attachment-0002.html>