[Webkit-unassigned] [Bug 139600] Split WebPageProxy::m_preventProcessSuppression to track pref/visibility separately

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139600

Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #243223|review?                     |review+
              Flags|                            |

--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 243223
  --> https://bugs.webkit.org/attachment.cgi?id=243223
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=243223&action=review

r=me

> Source/WebKit2/ChangeLog:9
> +        or it suppression was disabled by the pref. Instead track these separately. This will make the

"its"

> Source/WebKit2/ChangeLog:13
> +        ::updateProccessSuppressionState continues to track the pref change (which matches it's name),

"its"

> Source/WebKit2/UIProcess/WebPageProxy.h:1586
> +    RefPtr<RefCounter::Count> m_pageIsUserObservable;
> +    RefPtr<RefCounter::Count> m_preventProcessSuppression;

I wonder if we should put "Count" at the ends of these names.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141212/9258db3a/attachment-0002.html>