[Webkit-unassigned] [Bug 128974] WebGL EXT_blend_minmax may now be implemented

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=128974

--- Comment #6 from Roger Fong <roger_fong at apple.com> ---
(In reply to comment #5)
> Comment on attachment 243211 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243211&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        Tested by:
> > +        webgl/1.0.3/conformance/extensions/ext-blend-minmax.html
> > +        fast/canvas/webgl/constants.html
> 
> This is another one that is skipped by default. I think we should copy it in
> to fast/canvas/webgl or have a 1.0.3-ready directory with the non-skipped
> tests. What do you think?

So I actually unskipped that test on trunk but there are two different modes for the test. One where the extension is disabled and one when it's not.
So it was passing before because the extension wasn't enabled, and now it's still passing but running a different set of tests because it's enabled.

> 
> > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:18991
> >      <ClInclude Include="..\html\canvas\EXTFragDepth.h” />
> > +    <ClInclude Include="..\html\canvas\EXTBlendMinMax.h” />
> 
> Are these smart quotes or something?

o.0 guess so, odd that the first ones aren't.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141212/1ecf4d24/attachment-0002.html>