[Webkit-unassigned] [Bug 139568] WK1: Need new SPI for Webkit clients to override default immediate action

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 11 17:33:28 PST 2014


--- Comment #4 from mitz at webkit.org <mitz at webkit.org> ---
Comment on attachment 243166
  --> https://bugs.webkit.org/attachment.cgi?id=243166

View in context: https://bugs.webkit.org/attachment.cgi?id=243166&action=review

>> Source/WebKit/mac/WebView/WebImmediateActionController.mm:145
>> +    WebElementDictionary *webHitTestResult = [[[WebElementDictionary alloc] initWithHitTestResult:_hitTestResult] autorelease];
> We should only make this object if we need it (i.e. if the delegate responds to the selector).

Oh, and instead of autorelease we should RetainPtr it!

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141212/b5dffb0e/attachment-0002.html>

More information about the webkit-unassigned mailing list