[Webkit-unassigned] [Bug 139564] WK2: Need new SPI for Webkit clients to override default immediate action

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139564

--- Comment #6 from Beth Dakin <bdakin at apple.com> ---
(In reply to comment #5)
> Comment on attachment 243156 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=243156&action=review
> 
> > Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:197
> > +    id customClientAnimationController = [_wkView _immediateActionAnimationControllerForHitTestResult:toAPI(hitTestResult.get()) withType:_type userData:toAPI(_userData.get())];
> 
> I wonder if we should do this (and the early return) earlier so we avoid
> building a defaultAnimationController if we don't need it.

Good idea, but then we won't have the _type set yet!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141212/dc931c2e/attachment-0002.html>