[Webkit-unassigned] [Bug 139564] WK2: Need new SPI for Webkit clients to override default immediate action

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139564

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #243156|review?                     |review+
              Flags|                            |

--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 243156
  --> https://bugs.webkit.org/attachment.cgi?id=243156
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243156&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h:129
> +// do something custom, return an id that conforms to the NSImmediateActionAnimationController protocol.

"an object" instead of "an id", maybe.

> Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:201
> +    else if (customClientAnimationController && [customClientAnimationController conformsToProtocol:@protocol(NSImmediateActionAnimationController)])

No need for the else if because of the return.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141211/0baca3cc/attachment-0002.html>