[Webkit-unassigned] [Bug 138562] [GStreamer] GstGL support in the video sink

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138562

--- Comment #3 from Matthew Waters <ystreet00 at gmail.com> ---
Comment on attachment 243045
  --> https://bugs.webkit.org/attachment.cgi?id=243045
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243045&action=review

Looks good.  There doesn't seem to be any threading issues.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:316
> +                gst_gl_context_set_error(glMemory->context, "Failed to map intermediate memory");

gst_gl_context_set_error() simply GST_WARNING's in the GstGLContext debug category.  I would avoid using it for new code and call GST_WARNING yourself.

> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:444
> +    gst_caps_set_features(priv->glCaps, 0, glFeatures);

You probably also want to set the format here as well unless you're never going to deal with YUV formats.

> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:600
> +    gst_gl_handle_set_context(element, context, &sink->priv->display, &sink->priv->context);

shouldn't this be &sink->priv->otherContext or nullptr if you don't care?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141211/e63fbbba/attachment-0002.html>