[Webkit-unassigned] [Bug 139511] WK2: Add initial support for immediate actions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139511

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #243075|review?                     |review+
              Flags|                            |

--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 243075
  --> https://bugs.webkit.org/attachment.cgi?id=243075
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=243075&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:3611
> +        NSImmediateActionGestureRecognizer *recognizer = [[NSImmediateActionGestureRecognizer alloc] initWithTarget:nil action:NULL];

How does ownership work here?

> Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:84
> +    if ([immediateActionRecognizer view] != _wkView)

dot notation

> Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:96
> +    if ([immediateActionRecognizer view] != _wkView)

dotto

> Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm:117
> +    if ([immediateActionRecognizer view] != _wkView)

etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141210/74436554/attachment-0002.html>