[Webkit-unassigned] [Bug 139028] [GTK] Enable depth 32 for the RedirectedXCompositeWindow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139028

--- Comment #15 from Martin Robinson <mrobinson at webkit.org> ---
Comment on attachment 242914
  --> https://bugs.webkit.org/attachment.cgi?id=242914
[GTK] Enable depth 32 for the RedirectedXCompositeWindow

View in context: https://bugs.webkit.org/attachment.cgi?id=242914&action=review

Looks good to me, apart from a few nits.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:264
> +            [widget] { gtk_widget_queue_draw(widget); }

Please split this over multiple lines:
priv->redirectedWindow = RedirectedXCompositeWindow::create(
     GDK_DISPLAY_XDISPLAY(display),
     parentWindow ? GDK_WINDOW_XID(parentWindow) : 0,
     [widget] {
         gtk_widget_queue_draw(widget);
     });

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:1041
> +

Extra line here.

> Tools/MiniBrowser/gtk/main.c:69
> +    // Prefer RGBA visual if available.
> +    GdkScreen *screen = gtk_widget_get_screen(GTK_WIDGET(mainWindow));
> +    GdkVisual *visual = gdk_screen_get_rgba_visual(screen);
> +    if (visual)
> +        gtk_widget_set_visual(GTK_WIDGET(mainWindow), visual);
> +

So if this doesn't change the behavior of MiniBrowser, why is it necessary?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141210/a02ee6f3/attachment-0002.html>