[Webkit-unassigned] [Bug 133904] convertToUTF8String converts null string to empty string

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133904

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #242928|review?                     |review+
              Flags|                            |

--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 242928
  --> https://bugs.webkit.org/attachment.cgi?id=242928
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242928&action=review

Thanks!

> Source/WebCore/bindings/gobject/ConvertToUTF8String.cpp:33
> +        return 0;

nullptr

> Source/WebCore/bindings/gobject/ConvertToUTF8String.cpp:35
>      return g_strdup(s.utf8().data());

We could probably do something like return s.isNull() ? nullptr : g_strdup(s.utf8().data());

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141209/fdd83164/attachment-0002.html>